@fixed test unitaire

tests/Phoenix/Service/Comment/CommentHandlerTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Logipro\Phoenix\tests\Phoenix\Service\Comment;
 
 use PHPUnit\Framework\TestCase;
@@ -16,26 +17,28 @@ use Twig\Environment;
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Component\Security\Core\Security;
 
+use Logipro\Phoenix\Service\Session\SessionHandler;
+
 class CommentHandlerTest extends TestCase
-{	
+{
 	private $comment;
 	private $session;
 	private $person;
 
 
-    private $entityManager;
+	private $entityManager;
 
-    public function setUp()
-    {
+	public function setUp()
+	{
 		$this->person = new Person();
 		$this->person->setGivenName('Laurent');
 
-        $this->session = new SessionOpen();
+		$this->session = new SessionOpen();
 		$this->session->setTitle('Test CommentHandlerTest');
 
 		$this->comment = new Comment($this->person);
 		$this->comment->setContent('Mon commentaire');
-		$this->comment->setSession($this->session);	
+		$this->comment->setSession($this->session);
 	}
 
 	/**
@@ -54,10 +57,11 @@ class CommentHandlerTest extends TestCase
 		$translator = $this->createMock(TranslatorInterface::class);
 		$templing = $this->createMock(Environment::class);
 		$security = $this->createMock(Security::class);
+		$sessionHandler = $this->createMock(SessionHandler::class);
 
-		$commentHandler = new CommentHandler($dispatcher,$entityManager,$translator,$templing,$security);
-		$commentHandler->sendNotificationNewComment($this->comment, $this->session, 'session');	
-	}		
+		$commentHandler = new CommentHandler($dispatcher, $entityManager, $translator, $templing, $security, $sessionHandler);
+		$commentHandler->sendNotificationNewComment($this->comment, $this->session, 'session');
+	}
 
 	/**
 	 * Test pour verifier que le mail nouveau commentaire ne soit pas envoyé si l'option notifyMailForum est à false
@@ -75,8 +79,10 @@ class CommentHandlerTest extends TestCase
 		$templing = $this->createMock(Environment::class);
 		$security = $this->createMock(Security::class);
 
-		$commentHandler = new CommentHandler($dispatcher,$entityManager,$translator,$templing,$security);
-		$commentHandler->sendNotificationNewComment($this->comment, $this->session, 'session');	
+		$sessionHandler = $this->createMock(SessionHandler::class);
+
+		$commentHandler = new CommentHandler($dispatcher, $entityManager, $translator, $templing, $security, $sessionHandler);
+		$commentHandler->sendNotificationNewComment($this->comment, $this->session, 'session');
 	}
 
 
@@ -96,9 +102,11 @@ class CommentHandlerTest extends TestCase
 		$templing = $this->createMock(Environment::class);
 		$security = $this->createMock(Security::class);
 
-		$commentHandler = new CommentHandler($dispatcher,$entityManager,$translator,$templing,$security);
-		$commentHandler->sendNotificationNewComment($this->comment, $this->session, 'session');	
-	}	
+		$sessionHandler = $this->createMock(SessionHandler::class);
+
+		$commentHandler = new CommentHandler($dispatcher, $entityManager, $translator, $templing, $security, $sessionHandler);
+		$commentHandler->sendNotificationNewComment($this->comment, $this->session, 'session');
+	}
 
 	/**
 	 * Test pour verifier que le mail nouveau commentaire ne soit pas envoyé si il n'y a pas de responsable pédagogique
@@ -116,7 +124,9 @@ class CommentHandlerTest extends TestCase
 		$templing = $this->createMock(Environment::class);
 		$security = $this->createMock(Security::class);
 
-		$commentHandler = new CommentHandler($dispatcher,$entityManager,$translator,$templing,$security);
-		$commentHandler->sendNotificationNewComment($this->comment, $this->session, 'session');	
-	}	
-}
+		$sessionHandler = $this->createMock(SessionHandler::class);
+
+		$commentHandler = new CommentHandler($dispatcher, $entityManager, $translator, $templing, $security, $sessionHandler);
+		$commentHandler->sendNotificationNewComment($this->comment, $this->session, 'session');
+	}
+}

tests/Phoenix/Service/FormHandlerTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace Logipro\Phoenix\tests\Phoenix\Service;
 
 use Symfony\Component\Form\Test\TypeTestCase;
@@ -12,35 +13,36 @@ use Symfony\Component\Form\FormError;
 use Logipro\Phoenix\Service\FormHandler;
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\Form\FormFactoryInterface;
 
 class FormHandlerTest extends TypeTestCase
 {
-	private function generateHandler(bool $isMethod = true) : FormHandler
+	private function generateHandler(bool $isMethod = true): FormHandler
 	{
 		$requestStackMock = $this->createMock(RequestStack::class);
-		
+
 		$request = $this->createMock(Request::class);
 		$request->method('isMethod')->willReturn($isMethod);
-		
+
 		$requestStackMock->method('getCurrentRequest')->willReturn($request);
-		
+
 		$trnaslatorMock = $this->createMock(TranslatorInterface::class);
-		
-		return new FormHandler($requestStackMock,$trnaslatorMock);
+		$factoryMock = $this->createMock(FormFactoryInterface::class);
 
+		return new FormHandler($requestStackMock, $trnaslatorMock, $factoryMock);
 	}
-    public function testGetFormFieldError()
-    {
+	public function testGetFormFieldError()
+	{
 		$handler = $this->generateHandler();
 
 		$form = $this->factory->createBuilder(FormType::class)
 			->add('task', TextType::class)
 			->getForm();
 
-		$newError = new FormError('','');
+		$newError = new FormError('', '');
 		$taskField = $form->get('task');
 		// soumettre le formulaire sinon la validation ne se fait pas
-		$form->submit(array('task' => 'Fabien'),false);
+		$form->submit(array('task' => 'Fabien'), false);
 		$taskField->addError($newError);
 
 		$errors = $handler->getFormFieldError($form);
@@ -57,7 +59,7 @@ class FormHandlerTest extends TypeTestCase
 			$form
 		);
 	}
-	
+
 	/**
 	 * @expectedException \Exception
 	 *
@@ -68,13 +70,13 @@ class FormHandlerTest extends TypeTestCase
 		$handler = $this->generateHandler();
 
 		$form = $this->factory->createBuilder(FormType::class)
-		->add('task', TextType::class)
-		->getForm();
+			->add('task', TextType::class)
+			->getForm();
 
-		$newError = new FormError('','');
+		$newError = new FormError('', '');
 		$taskField = $form->get('task');
 		// soumettre le formulaire sinon la validation ne se fait pas
-		$form->submit(array('task' => 'Fabien'),false);
+		$form->submit(array('task' => 'Fabien'), false);
 		$taskField->addError($newError);
 
 		$handler->validForm($form);
@@ -94,4 +96,4 @@ class FormHandlerTest extends TypeTestCase
 
 		$handler->validate($form);
 	}
-}
+}